Skip to content

Conversation

lyonlu13
Copy link
Contributor

@lyonlu13 lyonlu13 commented Jan 25, 2024

TL;DR

Issue: flyteorg/flyte#3960

Implement execution tags displaying

  1. Normal
    image
  2. Archived
    image

Implement table filter for execution tags

image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  1. Add "tags" column for execution table.
  2. Use VALUE_IN operation to filter "admin_tag.name"
  3. Hash tag string into decimal number and present tag colors by HSL.

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Copy link

welcome bot commented Jan 25, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@lyonlu13 lyonlu13 marked this pull request as draft January 25, 2024 05:24
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: Patch coverage is 44.08602% with 52 lines in your changes missing coverage. Please review.

Project coverage is 63.04%. Comparing base (cfc38e4) to head (cac3afe).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...es/console/src/components/common/TagsInputForm.tsx 15.38% 33 Missing ⚠️
...omponents/Executions/filters/useTagsFilterState.ts 72.72% 9 Missing ⚠️
packages/console/src/components/utils/index.ts 16.66% 5 Missing ⚠️
...Executions/Tables/WorkflowExecutionTable/cells.tsx 66.66% 3 Missing ⚠️
...ole/src/components/Executions/ExecutionFilters.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   63.17%   63.04%   -0.14%     
==========================================
  Files         528      530       +2     
  Lines       13449    13542      +93     
  Branches     2567     2582      +15     
==========================================
+ Hits         8497     8538      +41     
- Misses       4952     5004      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyonlu13 lyonlu13 changed the title feat: display execution tags feat: display execution tags and filter Feb 2, 2024
@lyonlu13 lyonlu13 marked this pull request as ready for review February 2, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Cold PRs

Development

Successfully merging this pull request may close these issues.

1 participant