Skip to content

feat(log-panel): Add a button to show log panel in popup window #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+42 −7
Open

feat(log-panel): Add a button to show log panel in popup window #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 42 additions & 7 deletions ...s-console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import React, { FC, useEffect, useMemo, useRef, useState } from 'react';
import IconButton from '@mui/material/IconButton';
import Typography from '@mui/material/Typography';
import Modal from '@mui/material/Modal';
import Tab from '@mui/material/Tab';
import Tabs from '@mui/material/Tabs';
import ArrowBackIos from '@mui/icons-material/ArrowBackIos';
import Close from '@mui/icons-material/Close';
import OpenInFullIcon from '@mui/icons-material/OpenInFull';
import classnames from 'classnames';
import { LocationDescriptor } from 'history';
import Skeleton from 'react-loading-skeleton';
Expand Down Expand Up @@ -105,8 +107,8 @@ const StatusContainer = styled('div')(({ theme }) => ({
marginLeft: theme.spacing(1),
cursor: 'pointer',
},
'& .statusBody': {
marginTop: theme.spacing(2),
'& .reasonsIconContainer': {
textAlign: 'right',
},
}));

Expand All @@ -126,6 +128,23 @@ const NotRunStatus = styled('div')(({ theme }) => ({
fontWeight: 'bold',
}));

const ModalScrollableMonospaceText = styled(ScrollableMonospaceText)(({ theme }) => ({
'&': {
position: 'absolute' as 'absolute',
top: '50%',
left: '50%',
transform: 'translate(-50%, -50%)',
width: '85%',
height: '85%',
boxShadow: 12,
},
'& .container': {
maxHeight: '100%',
height: '100%',
flexDirection: 'column',
},
}));

const tabIds = {
executions: 'executions',
inputs: 'inputs',
Expand Down Expand Up @@ -227,6 +246,26 @@ const WorkflowTabs: React.FC<{
);
};

const TaskExecutionDetailReasons: React.FC<{ text: string }> = ({ text }) => {
const [open, setOpen] = useState(false);
const handleModalOpen = () => setOpen(true);
const handleModalClose = () => setOpen(false);

return (
<div>
<div className="reasonsIconContainer">
<IconButton onClick={handleModalOpen} title="Open in popup">
<OpenInFullIcon />
</IconButton>
</div>
<ScrollableMonospaceText text={text} />
<Modal open={open} onClose={handleModalClose}>
<ModalScrollableMonospaceText text={text} />
</Modal>
</div>
);
};

interface NodeExecutionStatusProps {
nodeExecution?: NodeExecution;
frontendPhase: NodeExecutionPhase;
Expand All @@ -248,11 +287,7 @@ const NodeExecutionStatus: FC<NodeExecutionStatusProps> = ({ nodeExecution, fron
<div className="statusHeaderContainer">
<ExecutionStatusBadge phase={frontendPhase} type="node" />
</div>
{reasons?.length ? (
<div className="statusBody">
<ScrollableMonospaceText text={reasons.join('\n\n')} />
</div>
) : null}
{reasons?.length && <TaskExecutionDetailReasons text={reasons.join('\n\n')} />}
</StatusContainer>
) : (
<NotRunStatus>NOT RUN</NotRunStatus>
Expand Down