Skip to content

fix: failure to decode BindingDataCollection #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

fix: failure to decode BindingDataCollection #894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/oss-console/src/common/decodeMsgPackLiterals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import core from '@clients/common/flyteidl/core';
import google from '@clients/common/flyteidl/google';
import $protobuf from 'protobufjs';
import { unpack } from 'msgpackr';
import isNil from 'lodash/isNil';
import entries from 'lodash/entries';
import isNil from 'lodash/isNil';
import { unpack } from 'msgpackr';
import $protobuf from 'protobufjs';

// Convert a JavaScript object to Protobuf Struct
function convertToStruct(obj: any) {
Expand All @@ -12,7 +12,7 @@
});

entries(obj).forEach(([key, value]) => {
struct.fields[key] = convertToValue(value);

Check warning on line 15 in packages/oss-console/src/common/decodeMsgPackLiterals.ts

View workflow job for this annotation

GitHub Actions / lint_project 

'convertToValue' was used before it was defined
});

return struct;
Expand Down Expand Up @@ -62,3 +62,9 @@
}
return result;
};

// const _originalBindingDataCollectionDecode = flyteidl.core.BindingData.decode;
core.BindingData.decode = (_reader: $protobuf.Reader | Uint8Array, _length?: number) => {
// bindings not used anywhere in the code (for now)
return {};
};
Loading