Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Dec 11, 2023

TL;DR

Bumping flytectl's flyte dependencies to 1.10.6. Can we make a new flytectl release after merging @wild-endeavor ?
There hasn't been a release yet which contains flyteorg/flyte#4189 and Mohd Shahid Khan Afridi has asked on Flyte Slack about this.

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@fg91 fg91 requested review from wild-endeavor and removed request for wild-endeavor December 11, 2023 14:14
@fg91 fg91 marked this pull request as draft December 11, 2023 14:19
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f10304d) 67.69% compared to head (cabb6b6) 67.69%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files         148      148           
  Lines        6622     6622           
=======================================
  Hits         4483     4483           
  Misses       1851     1851           
  Partials      288      288           
Flag Coverage Δ
unittests 67.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant