[feature/flytekit] Smarter copy handling with image spec#3070
Open
taieeuu wants to merge 5 commits intoflyteorg:masterfrom
Open
[feature/flytekit] Smarter copy handling with image spec#3070taieeuu wants to merge 5 commits intoflyteorg:masterfrom
taieeuu wants to merge 5 commits intoflyteorg:masterfrom
Conversation
Signed-off-by: taieeuu <taieeuu@gmail.com>
taieeuu
requested review from
Future-Outlier,
cosmicBboy,
eapolinario,
kumare3,
pingsutw,
samhita-alla,
thomasjpfan and
wild-endeavor
as code owners
Contributor
Code Review Agent Run #36f32bActionable Suggestions - 0Additional Suggestions - 1
Review Details
AI Code Review powered by |
Contributor
Changelist by BitoThis pull request implements the following key changes.
|
taieeuu
changed the title
Contributor
Code Review Agent Run #b288dcActionable Suggestions - 0Additional Suggestions - 10
Review Details
AI Code Review powered by |
pingsutw
reviewed
Jan 28, 2025
Contributor
Code Review Agent Run #70c125Actionable Suggestions - 1
Review Details
AI Code Review powered by |
flyte-bot
reviewed
Jan 28, 2025
Contributor
|
let us think about this... we're thinking through what the ideal experience is. |
Contributor
Author
|
Hi @wild-endeavor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to issue#6094
Why are the changes needed?
What changes were proposed in this pull request?
If you use the source_root parameter in imagespec, the command execution will use pyflyte-fast-execute; otherwise, it will use pyflyte-execute.
How was this patch tested?
the unit test pass.
Screenshots
Check all the applicable boxes
Summary by Bito
Implementation of enhanced container image handling in flytekit with improved validation logic and execution command determination. The system includes Kubernetes StatefulSet Data Service features, custom Python executable support, and smarter ImageSpec configurations. Changes focus on proper handling of container images, None value checks, and logic refinement for pyflyte-execute selection based on source_root parameters. The implementation includes improved error handling and CLI monitoring capabilities with configurable chunk sizes for data persistence.Unit tests added: True
Estimated effort to review (1-5, lower is better): 5