Skip to content

Silence union warning #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2025
Merged

Silence union warning #3091

merged 2 commits into from
Jan 25, 2025

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jan 25, 2025 •
edited by flyte-bot
Loading

Summary by Bito

Modified logging level in type engine module from warning to debug for union type transformations to reduce log noise while preserving debugging capabilities when needed.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

@wild-endeavor
silence union warning
e9c0e9b 
Signed-off-by: Yee Hing Tong <[email protected]>
@flyte-bot
Copy link
Contributor

flyte-bot commented Jan 25, 2025 •
edited
Loading

Code Review Agent Run #ceff6f

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: e9c0e9b..e9c0e9b
    • flytekit/core/type_engine.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Contributor

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Other Improvements - Logging Level Adjustment

- type_engine.py - Changed union type transformation log level from warning to debug

@Future-Outlier Future-Outlier enabled auto-merge (squash) January 25, 2025 06:01
@Future-Outlier Future-Outlier merged commit f0ba47f into master Jan 25, 2025
108 of 110 checks passed
@flyte-bot
Copy link
Contributor

flyte-bot commented Jan 25, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - We encountered technical difficulties while attempting to generate code feedback. Please try again or contact [email protected].

ChihTsungLu pushed a commit to ChihTsungLu/flytekit that referenced this pull request Jan 27, 2025
@wild-endeavor @ChihTsungLu
silence union warning (flyteorg#3091)
b102619 
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: lu00122 <[email protected]>
Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025
@wild-endeavor @Atharva1723
silence union warning (flyteorg#3091)
7080fce 
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Atharva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pingsutw pingsutw pingsutw approved these changes

@dansola dansola dansola approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan

+1 more reviewer

@Future-Outlier Future-Outlier Future-Outlier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wild-endeavor @flyte-bot @pingsutw @dansola @Future-Outlier