Refactor extract_types in Dict Transformer #3124
Merged
+132
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
thomasjpfan
as code owners
Code Review Agent Run #f8e289Actionable Suggestions - 1
Additional Suggestions - 1
Review Details
AI Code Review powered by |
Signed-off-by: Future-Outlier <[email protected]>
Changelist by BitoThis pull request implements the following key changes.
|
flyte-bot
reviewed
Feb 11, 2025
Future-Outlier
commented
Feb 11, 2025
Comment on lines
+2867
to
+2882
| "t,expected,allow_pickle", | ||
| [ | ||
| (None, (None, None)), | ||
| (typing.Dict, ()), | ||
| (typing.Dict[str, str], (str, str)), | ||
| (None, (None, None), False), | ||
| (typing.Dict, (), False), | ||
| (typing.Dict[str, str], (str, str), False), | ||
| ( | ||
| Annotated[typing.Dict[str, str], kwtypes(allow_pickle=True)], | ||
| (str, str), | ||
| Annotated[typing.Dict[str, str], kwtypes(allow_pickle=True)], | ||
| (str, str), | ||
| True, | ||
| ), | ||
| (typing.Dict[Annotated[str, "a-tag"], int], (Annotated[str, "a-tag"], int)), | ||
| (typing.Dict[Annotated[str, "a-tag"], int], (Annotated[str, "a-tag"], int), False), | ||
| ], | ||
| ) | ||
| def test_dict_get(t, expected): | ||
| def test_dict_get(t, expected, allow_pickle): | ||
| assert DictTransformer.extract_types(t) == expected | ||
|
|
||
| assert DictTransformer.is_pickle(t) == allow_pickle |
There was a problem hiding this comment.
This is a follow up for your PR, your PR make sense to me
#3123
Code Review Agent Run Status
|
|
Can you also add a test to cover the case described in flyteorg/flyte#6057? |
| # If this is something like Annotated[dict[int, str], FlyteAnnotation("abc")], | ||
| # we need to check if there's a FlyteAnnotation in the metadata. | ||
| if _origin is Annotated: | ||
| if not _args: |
There was a problem hiding this comment.
Can add a comment saying this should never happen. Python errors if you try to do Annotated[dict[str, str]] with
TypeError: Annotated[...] should be used with at least two arguments (a type and an annotation).
There was a problem hiding this comment.
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
|
Code Review Agent Run #059fd1Actionable Suggestions - 0Additional Suggestions - 10
Review Details
AI Code Review powered by |
Signed-off-by: Future-Outlier <[email protected]>
wild-endeavor
approved these changes
Feb 14, 2025
Code Review Agent Run #08028aActionable Suggestions - 1
Review Details
AI Code Review powered by |
flyte-bot
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3123
Why are the changes needed?
is_picklefunctionextract_typesWhat changes were proposed in this pull request?
is_picklein the above PR.How was this patch tested?
unit test.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR enhances Flytekit's type system with improved DictTransformer class and dictionary handling, while also upgrading the remote execution test suite. Key changes include new cache management system, expanded remote execution capabilities, and improved error logging with conditional display logic for better debugging visibility. The implementation covers msgpack encoding, pod template handling, and comprehensive test coverage.Unit tests added: True
Estimated effort to review (1-5, lower is better): 5