[BUG] sync_node_executions fails for workflows with FailureNodes #3268
Conversation
|
Bito Automatic Review Skipped - Draft PR |
machichima
force-pushed
the
6490-sync-node-exec-fail
branch
from
62a2003 to
f0897be
Compare
|
Bito Automatic Review Skipped - Draft PR |
1 similar comment
|
Bito Automatic Review Skipped - Draft PR |
machichima
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
| ) | ||
| mock_client = MagicMock() | ||
| mock_client.get_execution.return_value = admin_workflow_execution | ||
| mock_client.get_workflow.return_value.closure.compiled_workflow.primary.template.failure_node = None |
There was a problem hiding this comment.
Add this to ensure the failure node is None, otherwise it will be MagicMock
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
machichima
force-pushed
the
6490-sync-node-exec-fail
branch
from
eb657ee to
d87a800
Compare
-e Signed-off-by: machichima <[email protected]>
2 participants
Tracking issue
Part of flyteorg/flyte#6490
Why are the changes needed?
Getting error
ValueError: Missing node from mapping: fn0when using remote.wait on an execution that hasFailureNodespecified and the execution failsWhat changes were proposed in this pull request?
Adding failure node to
node_mappingHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request fixes a bug in workflow handling by improving the node mapping logic to include failure nodes during execution. It also introduces new tests to validate this functionality, enhancing robustness in failure scenarios.