Bugfix: AuthorizationClient hangs on invalid request #3306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mys007
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Signed-off-by: Martin Simonovsky <[email protected]>
mys007
force-pushed
the
authclient-bad-response-fix
branch
from
1a11e65 to
285ac3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
AuthorizationClient.get_creds_from_remote()is written in such a way that it waits for exactly one request from the browser. But if the request is invalid (i.e. does not contain the credentials), nothing is inserted in the queue and a follow-up call toauth_code = q.get()hangs forever.I have observed this happening when the first request succeeds but another (e.g. grpc) exception is raised, the authorization is retried and in the meantime, the browser tries to get "favicon.ico" from the callback server.
What changes were proposed in this pull request?
I added a loop which waits for a valid request.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request fixes a critical bug in the AuthorizationClient that caused indefinite hanging on invalid requests. A loop has been implemented to wait for valid requests, enhancing the robustness and reliability of the authorization process.