Skip to content

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Sep 29, 2025

Tracking issue

NA

Why are the changes needed?

Set the correct project for the BigQuery client

What changes were proposed in this pull request?

The project name in the client should be set to the one used in the structured dataset URI.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off

Summary by Bito

This pull request enhances the BigQuery client configuration by adding error handling for missing StructuredDataset URIs and ensuring the correct project name is set. These improvements increase the robustness of data handling and prevent potential runtime errors.

Signed-off-by: Kevin Su <[email protected]>
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.46%. Comparing base (23de1ab) to head (6d43894).

Files with missing lines Patch % Lines
flytekit/types/structured/bigquery.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (23de1ab) and HEAD (6d43894). Click for more details.

HEAD has 24 uploads less than BASE
Flag BASE (23de1ab) HEAD (6d43894)
25 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3330       +/-   ##
===========================================
- Coverage   79.55%   46.46%   -33.10%     
===========================================
  Files         215      215               
  Lines       22634    22564       -70     
  Branches     2965     2964        -1     
===========================================
- Hits        18007    10484     -7523     
- Misses       3791    11562     +7771     
+ Partials      836      518      -318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
wild-endeavor previously approved these changes Oct 2, 2025
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@flyte-bot
Copy link
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

@flyte-bot
Copy link
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

@pingsutw pingsutw requested a review from machichima as a code owner October 3, 2025 07:40
@pingsutw pingsutw enabled auto-merge (squash) October 3, 2025 07:55
@pingsutw pingsutw merged commit 95d1b34 into master Oct 3, 2025
115 checks passed
@flyte-bot
Copy link
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants