Skip to content

build: change flyte demo start command to make CI work #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

build: change flyte demo start command to make CI work #3332

merged 2 commits into from
Oct 2, 2025

Conversation

machichima
Copy link
Member

@machichima machichima commented Oct 2, 2025 •
edited
Loading

Tracking issue

Why are the changes needed?

CI can't pass and PR cannot be merged

What changes were proposed in this pull request?

Change flytectl demo start to flytectl demo start --disable-agent --image cr.flyte.org/flyteorg/flyte-sandbox-bundled:sha-3a102b9f4f9b83a150a01d885df1654d89561ce7 (use v1.16.0 image) for now to make CI pass

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@flyte-bot
Copy link
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

@machichima
build: set image
858f672 
Signed-off-by: machichima <[email protected]>
@flyte-bot
Copy link
Contributor

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

@machichima machichima changed the title build: try disable connector for flyte demo start build: change flyte demo start command to make CI work Oct 2, 2025
@machichima machichima enabled auto-merge (squash) October 2, 2025 07:08
@machichima machichima merged commit 9270511 into flyteorg:master Oct 2, 2025
115 checks passed
Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025
@machichima @Atharva1723
build: change flyte demo start command to make CI work (flyteorg#3332)
a62186a 
* build: try disable connector for flyte demo start

Signed-off-by: machichima <[email protected]>

* build: set image

Signed-off-by: machichima <[email protected]>

---------

Signed-off-by: machichima <[email protected]>
Signed-off-by: Atharva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pingsutw pingsutw pingsutw approved these changes

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

@davidmirror-ops davidmirror-ops Awaiting requested review from davidmirror-ops davidmirror-ops is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@machichima @flyte-bot @pingsutw