This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Simplify hive #89
Open
Simplify hive #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func (q QuboleHivePlugin) Get(ctx context.Context, meta remote.ResourceMeta) ( | ||
| newMeta remote.ResourceMeta, err error) { | ||
| r := meta.(Resource) |
There was a problem hiding this comment.
Can we not call this meta?
| } | ||
|
|
||
| func (q QuboleHivePlugin) Delete(ctx context.Context, meta remote.ResourceMeta) error { | ||
| r := meta.(Resource) |
There was a problem hiding this comment.
also here, don't like the name meta.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/