Improve clarity in code and docs#1052
Closed
DavidMertz wants to merge 3 commits intoflyteorg:masterfrom
DavidMertz:master
Closed
Improve clarity in code and docs#1052DavidMertz wants to merge 3 commits intoflyteorg:masterfrom DavidMertz:master
DavidMertz wants to merge 3 commits intoflyteorg:masterfrom
DavidMertz:master
Conversation
Signed-off-by: David Mertz <mertz@gnosis.cx>
ppiegaze
previously approved these changes
Jul 25, 2023
Member
ppiegaze
left a comment
ppiegaze
left a comment
There was a problem hiding this comment.
LGTM! A couple minor changes added.
| this case is `my_project`. | ||
| - Will not use any remote registry. | ||
| - Uses the git sha to version your tasks and workflows. | ||
| - Uses the git revision SHA1 to version your tasks and workflows. |
Member
There was a problem hiding this comment.
Suggested change
| - Uses the git revision SHA1 to version your tasks and workflows. | |
| - Uses the git revision ID (the SHA hash) to version your tasks and workflows. |
| this case is `flyte-package.tgz`. | ||
| - `--version`: This is a version string that can be any string, but we recommend | ||
| using the git sha in general, especially in production use cases. | ||
| using the git revision in general, especially in production use cases. |
Member
There was a problem hiding this comment.
Suggested change
| using the git revision in general, especially in production use cases. | |
| using the git revision ID (the SHA hash), especially in production use cases. |
cosmicBboy
reviewed
Jul 25, 2023
Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: David Q Mertz <mertz@gnosis.cx>
cosmicBboy
approved these changes
Jul 25, 2023
Contributor
|
looks like there are some linting issues. Will need to run pre-commit hooks to address those: https://docs.flyte.org/projects/cookbook/en/latest/contribute.html#pre-commit-hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only copy-edit style changes.
Attn: @ppiegaze