Skip to content

Conversation

eapolinario
Copy link

@eapolinario eapolinario commented Dec 17, 2024

We have a few unit tests, so let's make that those run in CI on PRs and merges to master.

edit: I also bumped the version to match the one in the main flyte repo since unit tests were failing to run in CI due to:

go: downloading golang.org/x/text v0.16.0
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/curve25519/curve25519.go:13:8: package crypto/ecdh is not in GOROOT (/opt/hostedtoolcache/go/1.18.10/x64/src/crypto/ecdh)
Error: Process completed with exit code 1.

@eapolinario eapolinario changed the title Run unit tests in CI Run unit tests in CI and use go 1.22 Dec 17, 2024
@ddl-ebrown
Copy link

@eapolinario wondering if you're going to get this one updated for Go 1.23?

I see the effort has started over at flyteorg/flyte#6249 for Flyte ... haven't looked closely enough at Stow or its dependencies to see if there are any Go 1.23 concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants