-
Notifications
You must be signed in to change notification settings - Fork 10
Refactoring & test FsGrid #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cscjlan
wants to merge
133
commits into
fmihpc:master
Choose a base branch
from
cschpc:refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary inheritance of the pointless struct
…hpp; Add unit tests for tools
…sts to unit tests
…function; Add test for comparing fsgrid display string to a reference string; Add testdata directory that's symlinked to build dir during build
…t any offset; Add tests
…assing local data as span.
… done now in one place
…other updateGhostCells that takes in FsData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor FsGrid
FsGrid is now a "singleton" in the sense that vlasiator uses only a single instance of it. It's a structure that has the coordinates for different spaces (global, rank local, physical), maps ranks to a 3D neighbourhood and stores
MPI_Datatype
information (offsets to arrays etc.) per neighbour.Data storage is now handled by a separate structure,
FsData
. It owns the data, storing the allocated pointer in astd::unique_ptr
. Currently it only allocates memory for the CPU (usingstd::malloc
), but it can be easily extended to allocate memory using Cuda, Hip, Sycl or any other API.Data is accessed with the help of
FsStencil
that computes 1D indices from 3D indices.FsGrid has a
parallel_for
method, which can be used to run some code (defined by a lambda) for each local cell of the fsgrid. Currently it's only implemented for the CPU.There are over 50 tests for FsGrid and related structs that assert the correct behaviour.
Other changes:
fsgrid.hpp
at root tosrc/grid.hpp
, whilefsgrid.hpp
still exists for single file include purpose