Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement glob patterns for lint translations #724

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement glob patterns for lint translations #724

wants to merge 2 commits into from

Conversation

qmenoret
Copy link

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller
    PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into
    two PRs otherwise).
  • This PR's title starts is concise and descriptive.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or
    fixes.
  • I've updated any docs, .md files, etc… affected by this change.

What

Allow for Globs for lint:translations.

Why

It's very hard to maintain a list of ignored translations when you have several locales and gems such as faker installed.
See: #707

Known limitations

Not sure

@qmenoret qmenoret requested a review from fnando as a code owner May 18, 2024 09:16
@Josyann Josyann mentioned this pull request Jun 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnando fnando Awaiting requested review from fnando fnando is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qmenoret