Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null() and not_null() will cause an error when running sync_schema(true) on a table with a foreign key constraint #1357

Merged
merged 5 commits into from
Dec 5, 2024
Merged

fix: null() and not_null() will cause an error when running sync_schema(true) on a table with a foreign key constraint #1357

merged 5 commits into from
Dec 5, 2024

Conversation

uuiid
Copy link

@uuiid uuiid commented Dec 4, 2024

@uuiid
fix: null() and not_null() will cause an error when running sync_sche…
e4b075b 
…ma(true) on a table with a foreign key constraint
@fnc12
Copy link
Owner

fnc12 commented Dec 4, 2024 •
edited
Loading

hey @uuiid . Thanks for this PR. Please run amalgamate script to update sqlite_orm.h as well
https://github.com/fnc12/sqlite_orm/wiki/Contribution-guide

  • run amalgamate

@uuiid
Copy link
Author

uuiid commented Dec 4, 2024

嘿@uuiid。感谢此 PR。请运行 amalgamate 脚本进行sqlite_orm.h更新 https://github.com/fnc12/sqlite_orm/wiki/Contribution-guide

  • 运行合并

ok

@fnc12
Copy link
Owner

fnc12 commented Dec 4, 2024

@uuiid it would be great if you add the code from the issue as unit test so this issue never appears again

@fnc12
Copy link
Owner

fnc12 commented Dec 4, 2024 •
edited
Loading

@uuiid looks perfect, thank you. Let's wait for CI to finish. If everything is ok I'll review and merge it

@fnc12
Copy link
Owner

fnc12 commented Dec 4, 2024

@uuiid your unit tests is failed in clang17 #1357. Please fix it

Снимок экрана 2024-12-04 в 22 41 16

@fnc12 fnc12 self-requested a review December 5, 2024 04:21
@uuiid
Copy link
Author

uuiid commented Dec 5, 2024

Already completed

@fnc12 fnc12 merged commit 0da82b0 into fnc12:dev Dec 5, 2024
2 checks passed
@fnc12
Copy link
Owner

fnc12 commented Dec 5, 2024

@uuiid merged. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnc12 fnc12 fnc12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uuiid @fnc12