Skip to content

Allow retrieval of all existing triggers (issue #1429) #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Allow retrieval of all existing triggers (issue #1429) #1434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5741865
Allow retrieval of all existing triggers (issue #1429)
HansH May 20, 2025
a470d74
Minor tweaks based on review (issue #1429)
HansH May 27, 2025
371780f
Add missing std::string construction (issue #1429)
HansH May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 33 additions & 18 deletions dev/storage_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,25 +278,16 @@ namespace sqlite_orm {
* @return Returns list of tables in database.
*/
std::vector<std::string> table_names() {
using data_t = std::vector<std::string>;
return this->object_names("table");
}

auto connection = this->get_connection();
data_t tableNames;
this->executor.perform_exec(
connection.get(),
"SELECT name FROM sqlite_master WHERE type='table'",
[](void* data, int argc, orm_gsl::zstring* argv, orm_gsl::zstring* /*columnName*/) -> int {
auto& tableNames_ = *(data_t*)data;
for (int i = 0; i < argc; ++i) {
if (argv[i]) {
tableNames_.emplace_back(argv[i]);
}
}
return 0;
},
&tableNames);
tableNames.shrink_to_fit();
return tableNames;
/**
* Returns existing permanent trigger names in database. Doesn't check storage itself - works only with
* actual database.
* @return Returns list of triggers in database.
*/
std::vector<std::string> trigger_names() {
return this->object_names("trigger");
}

/**
Expand Down Expand Up @@ -764,6 +755,30 @@ namespace sqlite_orm {
return res;
}

std::vector<std::string> object_names(const std::string& type) {
using data_t = std::vector<std::string>;

auto connection = this->get_connection();
data_t objectNames;
std::stringstream ss;
ss << "SELECT name FROM sqlite_master WHERE type = " << quote_string_literal(type);
this->executor.perform_exec(
connection.get(),
ss.str(),
[](void* data, int argc, orm_gsl::zstring* argv, orm_gsl::zstring* /*columnName*/) -> int {
auto& objectNames_ = *(data_t*)data;
for (int i = 0; i < argc; ++i) {
if (argv[i]) {
objectNames_.emplace_back(argv[i]);
}
}
return 0;
},
&objectNames);
objectNames.shrink_to_fit();
return objectNames;
}

#if SQLITE_VERSION_NUMBER >= 3006019
void foreign_keys(sqlite3* db, bool value) {
std::string sql;
Expand Down
51 changes: 33 additions & 18 deletions include/sqlite_orm/sqlite_orm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18310,25 +18310,16 @@ namespace sqlite_orm {
* @return Returns list of tables in database.
*/
std::vector<std::string> table_names() {
using data_t = std::vector<std::string>;
return this->object_names("table");
}

auto connection = this->get_connection();
data_t tableNames;
this->executor.perform_exec(
connection.get(),
"SELECT name FROM sqlite_master WHERE type='table'",
[](void* data, int argc, orm_gsl::zstring* argv, orm_gsl::zstring* /*columnName*/) -> int {
auto& tableNames_ = *(data_t*)data;
for (int i = 0; i < argc; ++i) {
if (argv[i]) {
tableNames_.emplace_back(argv[i]);
}
}
return 0;
},
&tableNames);
tableNames.shrink_to_fit();
return tableNames;
/**
* Returns existing permanent trigger names in database. Doesn't check storage itself - works only with
* actual database.
* @return Returns list of triggers in database.
*/
std::vector<std::string> trigger_names() {
return this->object_names("trigger");
}

/**
Expand Down Expand Up @@ -18796,6 +18787,30 @@ namespace sqlite_orm {
return res;
}

std::vector<std::string> object_names(const std::string& type) {
using data_t = std::vector<std::string>;

auto connection = this->get_connection();
data_t objectNames;
std::stringstream ss;
ss << "SELECT name FROM sqlite_master WHERE type = " << quote_string_literal(type);
this->executor.perform_exec(
connection.get(),
ss.str(),
[](void* data, int argc, orm_gsl::zstring* argv, orm_gsl::zstring* /*columnName*/) -> int {
auto& objectNames_ = *(data_t*)data;
for (int i = 0; i < argc; ++i) {
if (argv[i]) {
objectNames_.emplace_back(argv[i]);
}
}
return 0;
},
&objectNames);
objectNames.shrink_to_fit();
return objectNames;
}

#if SQLITE_VERSION_NUMBER >= 3006019
void foreign_keys(sqlite3* db, bool value) {
std::string sql;
Expand Down
28 changes: 28 additions & 0 deletions tests/trigger_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,34 @@ TEST_CASE("triggers_basics") {
}
}

TEST_CASE("trigger_names") {
auto storagePath = "trigger_names.sqlite";
struct X {
int test = 0;
};

{
auto storage = make_storage(
storagePath,
make_trigger("trigger1", after().insert().on<X>().begin(update_all(set(c(&X::test) = 1))).end()),
make_trigger("trigger2", after().insert().on<X>().begin(update_all(set(c(&X::test) = 2))).end()),
make_table("x", make_column("test", &X::test)));
storage.sync_schema();
}
{
auto storage = make_storage(
storagePath,
make_trigger("trigger2", after().insert().on<X>().begin(update_all(set(c(&X::test) = 2))).end()),
make_trigger("trigger3", after().insert().on<X>().begin(update_all(set(c(&X::test) = 3))).end()),
make_table("x", make_column("test", &X::test)));
storage.sync_schema();

auto trigger_names=storage.trigger_names();
REQUIRE_THAT(trigger_names,
Catch::Matchers::UnorderedEquals(std::vector<std::string>{"trigger1", "trigger2", "trigger3"}));
}
}

TEST_CASE("issue1280") {
struct X {
int test = 0;
Expand Down