-
Notifications
You must be signed in to change notification settings - Fork 1
UILD-579: General accessibility issues #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lity, add a couple missing other Stripes values
…ing focus outline
…der radius for button icon and link types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zepheiryan, Without any details in the PR description, it's hard to assess how the numerous CSS changes address the "Changes needed" section of the ticket. Even a high-level summary of the kinds of CSS changes you made, e.g. "added hover and focus styles for anchor tags", would be helpful.
The ticket describes at least three separate problems. Are all three resolved here? You could briefly describe the "before this PR" problems, and then use the screenshots to demonstrate "after this PR" solutions. As-is, it's hard to tell if the screenshots are showing the "areas of concern" that need attention, or if they're showing the solution.
Please update the CHANGELOG.
Thanks @zburke, I'll take that into account for future PRs intended for external review. I've made some updates to the PR description, but to answer the questions directly that the prior opaqueness provoked: yes, it addresses all three, and the screenshots are indeed intended to show the most important part of the solution. |
|
https://folio-org.atlassian.net/browse/UILD-579
This PR removes rules that disabled focus-visible indicators, updates button types to be more consistent, and aligns anchor and some button types' appearance across interaction states with Stripes. Aside from accessibility, it also updates Work titles in search results to align with UX designs.
Screenshots of tab-focused areas of concern fixed for this story, which would have had no visible indicators prior to these changes: