Skip to content

UILD-579: General accessibility issues #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 2, 2025
Merged

UILD-579: General accessibility issues #175

merged 9 commits into from
Jul 2, 2025

Conversation

zepheiryan
Copy link
Contributor

@zepheiryan zepheiryan commented Jul 1, 2025

https://folio-org.atlassian.net/browse/UILD-579

This PR removes rules that disabled focus-visible indicators, updates button types to be more consistent, and aligns anchor and some button types' appearance across interaction states with Stripes. Aside from accessibility, it also updates Work titles in search results to align with UX designs.

Screenshots of tab-focused areas of concern fixed for this story, which would have had no visible indicators prior to these changes:

Screenshot 2025-07-02 at 08 27 02 Screenshot 2025-07-02 at 08 27 08 Screenshot 2025-07-02 at 08 27 13

Copy link

github-actions bot commented Jul 1, 2025

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit ac64091. ± Comparison against base commit 03d2f7c.

♻️ This comment has been updated with latest results.

@zepheiryan zepheiryan requested review from pkjacob and a team July 2, 2025 15:35
@zepheiryan zepheiryan marked this pull request as ready for review July 2, 2025 15:39
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zepheiryan, Without any details in the PR description, it's hard to assess how the numerous CSS changes address the "Changes needed" section of the ticket. Even a high-level summary of the kinds of CSS changes you made, e.g. "added hover and focus styles for anchor tags", would be helpful.

The ticket describes at least three separate problems. Are all three resolved here? You could briefly describe the "before this PR" problems, and then use the screenshots to demonstrate "after this PR" solutions. As-is, it's hard to tell if the screenshots are showing the "areas of concern" that need attention, or if they're showing the solution.

Please update the CHANGELOG.

@zepheiryan
Copy link
Contributor Author

@zepheiryan, Without any details in the PR description, it's hard to assess how the numerous CSS changes address the "Changes needed" section of the ticket. Even a high-level summary of the kinds of CSS changes you made, e.g. "added hover and focus styles for anchor tags", would be helpful.

The ticket describes at least three separate problems. Are all three resolved here? You could briefly describe the "before this PR" problems, and then use the screenshots to demonstrate "after this PR" solutions. As-is, it's hard to tell if the screenshots are showing the "areas of concern" that need attention, or if they're showing the solution.

Please update the CHANGELOG.

Thanks @zburke, I'll take that into account for future PRs intended for external review. I've made some updates to the PR description, but to answer the questions directly that the prior opaqueness provoked: yes, it addresses all three, and the screenshots are indeed intended to show the most important part of the solution.

Copy link

sonarqubecloud bot commented Jul 2, 2025

@zepheiryan zepheiryan merged commit e815f57 into master Jul 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants