UILD-578: use separate profiles for Work and Instance #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file loading hooks
zburke
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Please update CHANGELOG.md.
Sorry, there's just not enough information here for me to usefully evaluate this work.
- The PR description is effectively blank
- The Jira feature is very high level, which is fine, but given the PR itself provides no additional details WRT an implementation plan, it is hard to understand
- There are no code comments aside from a few "TODO" entries
If you want a review from an external team, please provide more context generally, or point to a specific issue in the code that you think would benefit from scrutiny.
pkjacob
reviewed
Jul 2, 2025
zepheiryan
approved these changes
Jul 2, 2025
pkjacob
approved these changes
Jul 3, 2025
…into feat/UILD-578-separate-profiles
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading separate profiles for Work and Instance on the Create resource page
https://folio-org.atlassian.net/browse/UILD-578
Technical details:
The Create Work page now makes a request for the Work profile. The Create Instance page makes two requests: one for the Instance profile to render the work form and another for the Work profile to render the preview section with the linked Work data.
To implement this, a new hook has been introduced to load profiles, along with a new configuration to determine the root entry of the Monograph profile. Additionally, the general logic has been updated to apply the configuration and load the required profiles.