-
Notifications
You must be signed in to change notification settings - Fork 1
Correct URI scheme to http #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for consistency, and I will approve this simple PR on that principle and the fact that I recognize the users involved here and I know that you know what you're doing, but:
Moving to http from https feels like a step backward. While this one https feels like the outlier, how do we know it's not the last Right Thing holding down the fort of authentication and data integrity?as noted below, this value looks like a URL but here it's just an identifier, so http vs https is insignificant.- Is there a related Jira that describes why this work is necessary, i.e. countering the point above? That'll also provide visibility in Jira (where version information is tracked) into which release contains this fix. While we sometimes accept documentation changes that are unattached to tickets, it is expected that every code-change PR is linked to a Jira.
Hi @zepheiryan |
Thanks, @pkjacob , "RDF IDIs are identifiers, not necessarily fetch URLs" is exactly the kind of context I was looking for. The code in the file being changed here offers some misdirection (the variable containing this value is If your team wants feedback from @folio-org/fe-tl-reviewers, please make sure the PRs provide us with enough context to evaluate them :) I trust you to validate what ChatGPT is saying, but on my own I wouldn't know if that summary was legit or a hallucination. |
Correct this property scheme to match all others in this file.