Skip to content

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Jul 12, 2024

Purpose

Add MARC Settings page.

Description

This story is dedicated only to adding quick-marc settings.

Issues

UIQM-677

Approach

Sceenshots

image

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

github-actions bot commented Jul 12, 2024

Jest Unit Test Statistics

    1 files  ±0    45 suites  +1   2m 56s ⏱️ -5s
547 tests +1  547 ✔️ +1  0 💤 ±0  0 ±0 
549 runs  +1  549 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit c6960a1. ± Comparison against base commit 7ace603.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from a team and BogdanDenis July 12, 2024 15:35
const location = useLocation();
const { formatMessage } = useIntl();

const pages = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ask Khalilah or Christine if we can show MARC templates setting now. I think it's not planned for this release yet

@sonarqubecloud
Copy link

@github-actions
Copy link

github-actions bot commented Aug 14, 2025

Jest Unit Test Results

  1 files  ±0   46 suites  +1   2m 42s ⏱️ +3s
483 tests +1  483 ✅ +1  0 💤 ±0  0 ❌ ±0 
486 runs  +1  486 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 25a5212. ± Comparison against base commit 5ff81a1.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants