Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): ensure all fields for LazyPluginSpec are optional #1843

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

daephx
Copy link
Contributor

@daephx daephx commented Dec 9, 2024

After updating lua_ls to v3.13.3 noticed my plugin scripts using @type LazyPluginSpec now have missing-fields warnings.
It seems they have changed how missing-fields diagnostics work with inherited types: LuaLS/lua-language-server@7b2d585.

Duplicate offending fields as optional in type LazyPluginSpec

Closes: #1842

@folke folke merged commit 703be1d into folke:main Dec 9, 2024
10 checks passed
@folke
Copy link
Owner

folke commented Dec 9, 2024

ty!

@daephx daephx deleted the fix-type-spec branch December 9, 2024 21:54
folke pushed a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[11.16.1](v11.16.0...v11.16.1)
(2024-12-09)


### Bug Fixes

* **types:** ensure all fields for `LazyPluginSpec` are optional
([#1843](#1843))
([703be1d](703be1d)),
closes [#1842](#1842)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: type annotation for LazyPluginSpec result in missing-fields after updating to lua_ls v3.13.3
2 participants