fix(zathura): update template to accomodate new format #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guiltiest-gear
changed the title
guiltiest-gear
changed the title
guiltiest-gear
changed the title
guiltiest-gear
changed the title
fish.lua really did help with this
There has to be a better way of doing this
This took way too long to write and figure out how to do, I really hope this works
|
Code is at least in a working state, going to see if I can try to optimize it |
Lua implicitly converts the number to a string when interpolating, it's easier to read like this anyway
|
Nevermind, broke it again |
|
Alright, issue fixed, let me know if there's anything else that needs to be changed |
|
EDIT: Didn't see it was a local function, nevermind |
The code is significantly easier to read, easier to maintain, and generally much better looking with this change.
Unless some other file needs the ability to convert hex color codes to decimal, there isn't any need to move it to util.lua, keep the function at the lowest scope possible
|
This PR is stale because it has been open 30 days with no activity. |
|
Everything is ready to go, I've tested the code and gotten a successful build too. Would still say this is relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the zathurarc template to accommodate the new format for highlight-color and highlight-active-color.
Related Issue(s)
#641