Add instances_name_length_req check

[khaledhosny]

Description

Add instances_name_length_req check, similar to name_length_req, but checks the family and subfamily names of the instances, computed from STAT table.

Add the new check to Microsoft profile.

Also add failing test case for the new check as well as name_length_req.

Checklist

• update CHANGELOG.md
• wait for the tests to pass
• request a review

[felipesanches]

This is a new check added only to Microsoft profile.

@khaledhosny, do you think this check might be useful for other vendors or do you think it is certainly vendor-specific?

Option A

If you think it might be useful for other vendors, we'll add it to their "pending_review" lists.

Option B

On the other hand, if you think it is certainly vendor-specific, we'll rename it to microsoft/instances_name_length_req and move its source code to Lib/fontbakery/checks/vendorspecific/microsoft/instances_name_length_req.py.

[khaledhosny]

This is a new check added only to Microsoft profile.

@khaledhosny, do you think this check might be useful for other vendors or do you think it is certainly vendor-specific?

It should be the same as name_length_req.

[felipesanches]

This is a new check added only to Microsoft profile.

@khaledhosny, do you think this check might be useful for other vendors or do you think it is certainly vendor-specific?

Option A

If you think it might be useful for other vendors, we'll add it to their "pending_review" lists.

Option B

On the other hand, if you think it is certainly vendor-specific, we'll rename it to microsoft/instances_name_length_req and move its source code to Lib/fontbakery/checks/vendorspecific/microsoft/instances_name_length_req.py.

@khaledhosny please choose option A or B.

[khaledhosny]

I have no opinion here, it is up to you. name_length_req is not included in any other profile, and it does not currently have a vendor prefix (it was named com.microsoft/check/name_length_req when I submitted it). The two checks are similar and should be named similarly, giving one of them a vendor prefix and not the other seems inconsistent.

[felipesanches]

I have no opinion here, it is up to you. name_length_req is not included in any other profile, and it does not currently have a vendor prefix (it was named com.microsoft/check/name_length_req when I submitted it). The two checks are similar and should be named similarly, giving one of them a vendor prefix and not the other seems inconsistent.

OK. Your answer sounds like option A. So I'll add it to the "pending review" lists of all other profiles, signaling that we believe this should be considered for broader adoption.

[khaledhosny]

OK. Your answer sounds like option A. So I'll add it to the "pending review" lists of all other profiles, signaling that we believe this should be considered for broader adoption.

I’ve added it to pending review lists of various vendor profiles.