create financial link for invoice #1079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjavurek
changed the title
|
Thank you for your contribution, @mjavurek - looks reasonable! Just a general observation: There are currently no unit tests whatsoever for Since I'm not too deep into all of this BankTransactions/FinancialTransactions logic, I'm finding it hard to review such changes. Maybe someone knowing their way around them can find the time to add tests before we review/merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, financial links can only be created for bank transactions. In this PR, a "add finance link" button is added to the invoice view unless there is already a finance link.
This is useful if invoices are not paid from the bank account of the foodcoop, but from a foodcoop member (e.g. by credit card). In this case, a foodcoop transaction is required instead of a bank transaction to pay the invoice by crediting the invoice amount to the foodcoop member. After creating a finance link for the invoice, a foodcoop transaction can be easily generated and linked to the invoice. The following screenshot is from another invoice with a different amount than the invoice in the previous screenshot.