Skip to content

Fix transport cost related issues #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix transport cost related issues #1082

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c37785
Fix transport cost related issues
twothreenine Jan 27, 2025
1c219c7
First try for better calculation of groups_without_markup
twothreenine Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/models/order.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,12 @@ def sum(type = :gross)
when :groups
total += go.total
when :groups_without_markup
go_price_without_markup = 0
for goa in go.group_order_articles
total += goa.result * goa.order_article.article_version.gross_group_order_price
go_price_without_markup += goa.result * goa.order_article.article_version.gross_group_order_price
end
total += go_price_without_markup.round(2) || 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why's the || 0 needed here?

total += go.transport if go.transport
end
end
end
Expand Down
Loading