V4.9.2

[RayOei]

Bumped to 4.9.2

• Layout improvements and fixes in transaction overview
• Added missing translation entries
• Improves [BUG]: Mollie API doesn't contain pricing information anymore #1178
• Includes hot fix ec17071

Note: merging to main release branch/trunk for future v4.x releases.

[RayOei]

@twothreenine @lentschi FYI: see #1199 (comment) and onwards on the juggling of branches.
Goal is to end-up with a v4.x branch/trunk for future v4 releases.
PR #1203 is also targeted to merge onto v4.x.

[RayOei]

Added @robwa too, if you are able 😁

[lentschi]

FYI: see #1199 (comment) and onwards on the juggling of branches.

I'm a bit confused by the discussion in #1199 and the effect in this PR: Is this PR just a collection of cherry-picks from master?.

If so, I wonder if they are all really necessary. For example fixing typos like here doesn't really make sense to me in a legacy branch unless we want to support said legacy branch for a long time and thus do a lot of other cherry-picks until it's abandoned. Is that the case and the reason why you did it?

EDIT: Ah, sorry - just saw, that you're cherry-picking from 4.x, but still: Haven't these changes been reviewed elsewhere and if so, how can we find the reviews to check if the cherry-picks could cause trouble in this case?

[RayOei]

Cherry picking is done separately. I am reviewing those as we speak 😁 As soon as I re-push that branch, I encountered an issue, I will add the commits as well. Only a few but some do bother the FCAN users at this time. As long as v4 is not abandonded adding (minor) improvements is not a bad thing, in my book anyway.
The branches discussion was about being able to clearly separate v4.x and v5.x. As there were a few different ideas floating around in branches in the past, it got a bit messy. We settled now on using the v4.x one for future updates on v4.

Part of the fixing/improving here was also meant as a way to get a bit better acquinted with the code. It is not imperative but does provide a few minor tweaks. I did find an issue yesterday, I left a Mollie specific item in there by accident, which I am going to address soon. Again also part of me getting to understand the plugin idea a bit better.

As a side note: while cleaning up the release4 confusion I also killed the Mollie PR as part of the cleaning. I will reintroduce that soon, as that does provide a needed fix for payments and missing fees.