Results Caching #69
Closed
Results Caching #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement in-memory caching mechanism with: - CacheKey struct for unique request identification - CacheEntry with TTL support - Thread-safe InMemoryCache implementation - Lazy expiration on access - Comprehensive unit tests
- Update collector factory to accept cache instance - Add cache checks before PageSpeed API calls - Store successful results in cache - Update tests to pass cache parameter
- Add PAGESPEED_CACHE_TTL environment variable support - Parse cache TTL with 15-minute default - Initialize cache and pass to collector factory - Add --cache-ttl command line flag
Document the design and implementation details for the in-memory caching mechanism including requirements, architecture, and testing strategy.
- Add cache-ttl flag to configuration table - Add dedicated Caching section explaining the feature - Update examples to show cache usage - Add cache environment variable to Docker examples
- Add cache directory to .gitignore - Update Dockerfile to create cache directory with proper permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.