This class needs to be public so surefire don't crash running the tests #353
Conversation
Now if captcha is properly configured, verification is done. This ensures it is easier and shorter to install the software for testing purposes.
If the email server isn't configured, just don't send a confirmation email. This helps setting up the server quickly for testing purposes.
Also fixed whitespace to put as unix eol, as per github guidelines: Use `git diff --ignore-space-at-eol README.md` to see changes.
…utoselects the tagset of the selected tag
…st of selected tags I take baby steps. I need to do this if I want the addSubtagDialog to show a box containing the currently selected tag in TagsView object, which is currently not sent down to the dialog.
More baby steps. I still need to fix the ListBox items shown, but there is a listbox which allow multiple select, and the listbox feeds on TagDefinition. Its getting somewhere.
This is still broken, it should only show the current tagset we're working on, but that is from a regression introduced in previous baby step.
The whole code seems to be designed around the fact that you can select multiple parents, even though the tag selection is singleSelect. It would be straightforward to convert this to a ComboBox. When you select multiple parents, a copy of the tag is added into each parent. This feature is not really requested, but a) its not completely useless, b) and the whole edit subtag with tagset selection and parent tag selection actually need most of that code, might has well try to develop and test it first in a separate block.
…working Only a) making it look nice, b) and having a listener if there is multiple tagsets is left.
When you edit a tag, by default it shows its parent in its own tagset. If multiple tagsets are selected, you can navigate among them, and the parent choice select box shows the potential list of parent from that tagset.
I had to make sure that there were only one tag selected
… functions that sends down the info to the deepest layers
… a note that the old def was removed Also optimized a bit
…owing the hierarchy changes
… the tree) and fixed a bug that crashed the backend
It would have been an easy feature to add, but I won't have time to finish it
…the UI This is to prevent the tags from being separated from their parents
…dren and avoid extra steps
Helps the UI feels smoother
|
@GuillaumeFromage This PR appears to contain everything that is included in your other PRs, plus some extra bits. It's a bit difficult to tell as the commit hashes are different and one has to compare based on the messages. I had a look at the first two commits related to the tests (as the PR title is about tests), however all tests are passing for me without those changes. You commented that this gets the tests to run on JDK11, but we were still targeting 1.8 at the time you made your changes. Perhaps the failures were related to that. The current version is now targeting JDK21. Therefore I'm tempted to simply close this PR and concentrate on the others. Please check whether there is anything in here that you think should be merged and isn't included in the other PRs. |
|
Hi Malte, Sorry for delays ; I didn't realized that you absolutely need to make a custom branch to make a pull request, any ulterior commits on the branch (here master) gets added at the end. If stuff compiles on your end without that class "public" thing, that's awesome, its just my setup that is weird, so indeed don't worry about it. Let me know if you need help with any other patches. G |
This gets the catma to runs tests on jdk11