NEW (SFGE) @W-17915877@ PathStart functionality for SFGE #250
Conversation
jfeingold35
force-pushed
the
d/W-17915877
branch
from
4640ea7 to
96105bc
Compare
| } | ||
| final ProjectFileVisitor projectFileVisitor = new ProjectFileVisitor(); | ||
| if (this.pathsWalked.contains(path.toString())) { |
There was a problem hiding this comment.
This matters because when the sourceFolder paths are lists of individual files in the same folder, then path will end up being the same for all of them and we don't want to walk the same path trees repeatedly.
| @@ -61,13 +63,21 @@ public TreeSet<String> getMetaInfoCollected() { | |||
|
|
|||
| private void processSourceFolder(String sourceFolder) throws MetaInfoLoadException { | |||
There was a problem hiding this comment.
Technically, sourceFolders can now be a list of files.
But I didn't want to chase down and rename a million different variables, so I didn't do that. I can if people want, but I think I'd prefer to do it in a follow-up PR to keep this one readable.
There was a problem hiding this comment.
I don't mind it as a follow-up! Sounds like a good cleanup item 👍
There was a problem hiding this comment.
Actually in reading through the code, I think sourceFolder for the parameter is still right, isn't it? Later I see this, and the invocation reads right to me:
for (String sourceFolder : sourceFolders) {
processSourceFolder(sourceFolder);
}
| this.config = config; | ||
| const javaCommandExecutor: JavaCommandExecutor = new JavaCommandExecutor(this.config.java_command, this.emitLogEvent.bind(this)); |
There was a problem hiding this comment.
Forgot to do this the first time around. Doing it now.
| @@ -61,13 +63,21 @@ public TreeSet<String> getMetaInfoCollected() { | |||
|
|
|||
| private void processSourceFolder(String sourceFolder) throws MetaInfoLoadException { | |||
There was a problem hiding this comment.
I don't mind it as a follow-up! Sounds like a good cleanup item 👍
| // So we'll go up a level before walking the file tree. | ||
| if (directoryContainsApex(path)) { | ||
| if (isDirectoryContainingApex(path)) { | ||
| // If the path is a directory with apex files in it, we should assume it's the class folder, and that project |
There was a problem hiding this comment.
| // If the path is a directory with apex files in it, we should assume it's the class folder, and that project | |
| // If the path is a directory with apex files in it, we should assume it's the classes folder, and that project |
| path = path.getParent(); | ||
| } else if (isApexFile(path)) { | ||
| // If the path itself is an apex file, we should assume that it is contained in the class folder, and that |
There was a problem hiding this comment.
| // If the path itself is an apex file, we should assume that it is contained in the class folder, and that | |
| // If the path itself is an apex file, we should assume that it is contained in the classes folder, and that |
| path = path.getParent(); | ||
| } else if (isApexFile(path)) { | ||
| // If the path itself is an apex file, we should assume that it is contained in the class folder, and that | ||
| // project files are in a sibling of its parent directory. So we'll go up two levels before walking the file |
There was a problem hiding this comment.
Can you clarify for me what you mean by "project files" here?
| @@ -61,13 +63,21 @@ public TreeSet<String> getMetaInfoCollected() { | |||
|
|
|||
| private void processSourceFolder(String sourceFolder) throws MetaInfoLoadException { | |||
There was a problem hiding this comment.
Actually in reading through the code, I think sourceFolder for the parameter is still right, isn't it? Later I see this, and the invocation reads right to me:
for (String sourceFolder : sourceFolders) {
processSourceFolder(sourceFolder);
}
This PR does the following:
projectDirsproperty consisting of a list of individual files.pathStartproperty onrunOptionsin SFGE.