NEW: @W-18495367@: Make a copy of eslint engine into code-analyzer-eslint8-engine and update its package.json #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lint8-engine and update its package.json
Comment on lines
+2
to
+3
| "name": "@salesforce/code-analyzer-eslint8-engine", | ||
| "description": "Plugin package that adds 'eslint' (version 8) as an engine into Salesforce Code Analyzer", |
There was a problem hiding this comment.
These changed and the directory changed.
| "dependencies": { | ||
| "@babel/core": "^7.26.7", | ||
| "@babel/eslint-parser": "^7.27.0", | ||
| "@eslint/js": "8.57.1", |
There was a problem hiding this comment.
Locking in a few of these (removing the ^ as discussed in the spike doc).
| import {ESLINT_ENGINE_CONFIG_DESCRIPTION, ESLint8EngineConfig, validateAndNormalizeConfig} from "./config"; | ||
| import {ESLint8Engine} from "./engine"; | ||
|
|
||
| export class ESLint8EnginePlugin extends EnginePluginV1 { |
There was a problem hiding this comment.
Renamed the plugin
| import {getMessage} from "./messages"; | ||
| import {RULE_MAPPINGS} from "./rule-mappings"; | ||
|
|
||
| export class ESLint8Engine extends Engine { |
There was a problem hiding this comment.
Renamed the engine class
| import {RULE_MAPPINGS} from "./rule-mappings"; | ||
|
|
||
| export class ESLint8Engine extends Engine { | ||
| static readonly NAME = "eslint"; |
There was a problem hiding this comment.
Keeping the engine name as 'eslint' for now.
jfeingold35
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just makes a copy and updates the engine and plugin names, updates the package.json, and the build script. It doesn't modify the existing code-analyzer-eslint-engine (which will come in the next PR).