NEW: @W-18495430@: Update devDependencies to use eslint v9 #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/eslintV9Prep
branch
from
c1f08be to
3f5fff0
Compare
| "jest": "^29.7.0", | ||
| "rimraf": "*", | ||
| "ts-jest": "29.3.2", | ||
| "ts-jest": "^29.3.2", |
There was a problem hiding this comment.
Back with https://github.com/forcedotcom/code-analyzer-core/pull/261/files#diff-8c263af063232c1af728f80b0ebe7407da27dc2a4805c3f9c8a75725f81046bd it looks like @randi274 forgot to put back the ^ on ts-jest after we were unblocked. So fixing that here as well.
| "typescript": "^5.8.3", | ||
| "typescript-eslint": "^8.30.1", | ||
| "typescript-eslint": "8.30.1", |
There was a problem hiding this comment.
Forgot to lock this in for the eslint8-engine ... so eslint8-engine will have everything it needs in its own node_modules folder local to its package separate from top level one.
stephen-carter-at-sf
force-pushed
the
sc/eslintV9Prep
branch
from
3f5fff0 to
e671dfa
Compare
stephen-carter-at-sf
force-pushed
the
sc/eslintV9Prep
branch
from
e671dfa to
70b0c30
Compare
| @@ -181,7 +181,7 @@ export class LegacyESLintStrategy implements ESLintStrategy { | |||
| overrideConfigFile: userConfigInfo.getUserConfigFile(), // This is applied third. | |||
| overrideConfig: overrideConfig as Linter.Config, // This is applied fourth (on top). | |||
| ignorePath: userConfigInfo.getUserIgnoreFile() | |||
| }; | |||
| } as ESLint.Options; | |||
There was a problem hiding this comment.
Makes IDE Happy because IDE struggles a little bit resolving this one type with both versions of ESLint installed.
jfeingold35
approved these changes
May 12, 2025
stephen-carter-at-sf
force-pushed
the
sc/eslintV9Prep
branch
from
da02b20 to
2459fdd
Compare
stephen-carter-at-sf
force-pushed
the
sc/eslintV9Prep
branch
3 times, most recently
from
07cd73b to
c2eb769
Compare
… module that are greater than the eslint8-engine
stephen-carter-at-sf
force-pushed
the
sc/eslintV9Prep
branch
from
c2eb769 to
1206a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this the code-analyzer-eslint8-engine module obviously will be stuck on eslint v8. And note that this simply prepares the way for us to use eslint 9 with our code-analyzer-eslint-engine but that engine implementation is still to come.