Skip to content

FIX(eslint8): @W-18558198@: Use cwd as basedir if no base configs are used … #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

stephen-carter-at-sf
Copy link
Collaborator

…so that custom overrides work

@stephen-carter-at-sf stephen-carter-at-sf changed the title FIX(eslint8): W-18558198: Use cwd as basedir if no base configs are used … FIX(eslint8): @W-18558198@: Use cwd as basedir if no base configs are used … May 19, 2025
@stephen-carter-at-sf
Copy link
Collaborator Author

fixes: forcedotcom/code-analyzer#1807

@stephen-carter-at-sf
Copy link
Collaborator Author

Unfortunately, the only way to test this will be to create a temp folder and unzip a massive folder with a bunch of node modules. Since we will be moving towards ESLint 9 soon... I don't think it's worth adding in a big zip file for this one case. Instead, we should just QA this fix.

@stephen-carter-at-sf stephen-carter-at-sf merged commit 425a669 into dev May 19, 2025
12 of 13 checks passed
@stephen-carter-at-sf stephen-carter-at-sf deleted the sc/W-18558198 branch May 19, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants