NEW: @W-16092798@ Remove unwanted paths from workspace #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sf/W-16092798
branch
2 times, most recently
from
0bc35f0 to
4850f2b
Compare
jag-j
reviewed
Jun 27, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@salesforce/code-analyzer-core", | |||
| "description": "Core Package for the Salesforce Code Analyzer", | |||
| "version": "0.5.0", | |||
| "version": "0.5.1", | |||
There was a problem hiding this comment.
What is the strategy we follow around versioning in the core library? Like when do we increase minor/patch versions?
There was a problem hiding this comment.
Right now things are pretty loosy goosy before we get to v1.x. I'm considering this a fundamental missing component and thus I'm treating it sort of like a bug to be patched. So instead of incrementing it up a full minor step... just making this a patch update.
jag-j
reviewed
Jun 27, 2024
| @@ -35,6 +35,14 @@ describe("Tests for the createWorkspace method of CodeAnalyzer", () => { | |||
| expect(workspace.getFilesAndFolders()).toEqual([path.resolve('test')]); | |||
| }); | |||
|
|
|||
| it("When including a .gitignore file or a node_modules folder, then it they are removed", async () => { | |||
There was a problem hiding this comment.
typo here. Did you mean "then test they are removed?"
There was a problem hiding this comment.
Yes that was a typo... fixed. Thanks.
jag-j
approved these changes
Jun 27, 2024
stephen-carter-at-sf
force-pushed
the
sf/W-16092798
branch
from
4850f2b to
7e38ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.