CHANGE: @W-16092798@ Update workspace to be optional and add testtools #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sf/W-16092798
branch
from
e355fdb to
c51b84d
Compare
stephen-carter-at-sf
force-pushed
the
sf/W-16092798
branch
from
c51b84d to
5cb6ff9
Compare
stephen-carter-at-sf
changed the title
jfeingold35
reviewed
Jun 28, 2024
| @@ -133,7 +132,7 @@ export class CodeAnalyzer { | |||
| this.eventEmitter.on(eventType, callback); | |||
| } | |||
|
|
|||
| private async getAllRules(workspace: Workspace): Promise<RuleImpl[]> { | |||
| private async getAllRules(workspace: Workspace | undefined): Promise<RuleImpl[]> { | |||
There was a problem hiding this comment.
Why declare it this way instead of as workspace?: Workspace?
There was a problem hiding this comment.
Ah good point. will fix.
| import {LogLevel, RuleType, SeverityLevel} from "../src"; | ||
| import * as engApi from "@salesforce/code-analyzer-engine-api"; | ||
|
|
||
| describe('Misc tests', () => { |
There was a problem hiding this comment.
Categorizing tests as "misc" tends to bug me, but I don't have a better name in mind. Maybe "interoperability"?
There was a problem hiding this comment.
Fair point... will update.
jfeingold35
approved these changes
Jun 28, 2024
stephen-carter-at-sf
force-pushed
the
sf/W-16092798
branch
from
a3e0398 to
2243402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.