NEW: @W-15884468@: Implement eslint engine's describeRules method #37
Conversation
stephen-carter-at-sf
force-pushed
the
sf/W-15884468
branch
from
3708768 to
3243432
Compare
| } | ||
| } | ||
|
|
||
| function toSeverityLevel(metadata: Rule.RuleMetaData, status: ESLintRuleStatus | undefined): SeverityLevel { |
There was a problem hiding this comment.
This has some convoluted matching logic here. Would really help to have some comments as to why we are doing this.
There was a problem hiding this comment.
Sure... will do. Note that our eslint engine design doc contains more info: https://docs.google.com/document/d/13M9nhS4tkhendq-9mRelnqP_rGU322mP7X0Ncxu-7Fs/edit#heading=h.uvab9trr4ep7
There was a problem hiding this comment.
OK, added in comments.
| return this.ruleStatuses; | ||
| } | ||
|
|
||
| private async calculateRuleStatusesFor(files: string[], legacyESLint: ESLint): Promise<Map<string, ESLintRuleStatus>> { |
There was a problem hiding this comment.
Will this be the only method that changes with eslint 9? I'm trying to understand how much of this would change with config changes in eslint 9.
There was a problem hiding this comment.
The new flat config files (also available in eslint 8) will indeed require us to use the loadESLint utility to get a new ESLint constructor that is for flat configuration files. Therefore we will need to:
- Construct our base configs off of the new flat config structure
- Construct the ESLint instance from loadESLint instead of manually constructing the legacy one
- And the biggest one will be... in order to get metadata for the rules, we'll need to import and process all of the users configuration files and the import and process all of the plugin modules that we find along the way to get access to the rule metadata.
stephen-carter-at-sf
force-pushed
the
sf/W-15884468
branch
3 times, most recently
from
8a88f99 to
8854cf2
Compare
stephen-carter-at-sf
force-pushed
the
sf/W-15884468
branch
from
1621120 to
ebe79f7
Compare
stephen-carter-at-sf
force-pushed
the
sf/W-15884468
branch
2 times, most recently
from
93d8855 to
cad18ad
Compare
stephen-carter-at-sf
force-pushed
the
sf/W-15884468
branch
from
cad18ad to
0e0f79f
Compare
No description provided.