NEW @W-20773626@ ESLint rules for react typescript static analysis #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruntyagiTutu
changed the title
aruntyagiTutu
changed the title
namrata111f
reviewed
Jan 8, 2026
Contributor
There was a problem hiding this comment.
1- Let's test for the existing Typescript code as well to verify no regression for it. The Typescript violations should continue to be reported as expected.
2- React Team has shared one good repo with .tsx file for testing: https://github.com/salesforce-experience-platform-emu/vibe-coding-starter/tree/main/static-app/src/components. We can verify if the violations reported on these files are valid.
namrata111f
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part1 - Modularize ESLint rule mappings and related refactors
Changes (by area)
ESLint engine
Split RULE_MAPPINGS into per-plugin modules; aggregate in src/rule-mappings.ts.
Added shared tag constants in src/rule-mappings/constants.ts.
[Add other changes here as you commit them, e.g., config tweaks, docs, tests, etc.]
No behavioral changes expected; only file-structure refactor for rule mappings.
Risk and compatibility
Low risk; RULE_MAPPINGS export path and shape unchanged.
Consumers importing ./rule-mappings remain unaffected.
part2 - updated tests and added relevent tests
part3 - Added two entries to .vscode/launch.json:
Debug engine.test.ts (single test): runs a targeted Jest test in-band, no coverage.
Debug Jest (watch all): watch mode for all tests in-band, no coverage.
Uses NODE_OPTIONS=--experimental-vm-modules and integrated terminal.
Non-breaking; existing configs retained.
Demo: https://salesforce-internal.slack.com/archives/G02JGHG9NSE/p1767964298744989