NEW (eslint): @W-16113415@: Implement the runRules method of eslint engine #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/W-16113415
branch
4 times, most recently
from
c856d2c to
792d7ff
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-16113413
branch
from
b62d887 to
979acbb
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-16113415
branch
from
792d7ff to
a2f366c
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-16113413
branch
from
979acbb to
8b5141c
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-16113415
branch
from
a2f366c to
7846971
Compare
Comment on lines
+16
to
+20
| /** | ||
| * NOTE THAT WE WANT TO KEEP THE AMOUNT OF TESTS HERE TO A MINIMUM! | ||
| * All functionality should be tested at the unit level. This file ideally should only contain 1 (maybe 2) tests | ||
| * at most to simply confirm that things can wire up correctly without failure. | ||
| */ |
There was a problem hiding this comment.
Currently these tests don't provide much value over the actual engine tests... so if you are wondering why I have them, it is part of a bigger picture idea:
I'd like to create a pseudo end to end test for each engine... so that eventually we can see the common overlapping pattern between them all which will eventually help me create a generalized end-to-end test utility that can live in the engine api (which will eventually help engine api authors to testing more easily). After one or two more engines, i think we'll have enough information to then create the generalized utility.
stephen-carter-at-sf
force-pushed
the
sc/W-16113415
branch
from
babe994 to
59b7c78
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-16113415
branch
from
59b7c78 to
ff3a022
Compare
jfeingold35
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.