NEW @W-21364933@ Adding changes for inline suppression marker#440
Merged
namrata111f merged 7 commits intodevfrom Mar 18, 2026
Merged
NEW @W-21364933@ Adding changes for inline suppression marker#440namrata111f merged 7 commits intodevfrom
namrata111f merged 7 commits intodevfrom
Conversation
namrata111f
force-pushed
the
ng-inline-suppress
branch
from
8cf6a12 to
fae1681
Compare
Contributor
aruntyagiTutu
left a comment
aruntyagiTutu
left a comment
There was a problem hiding this comment.
as discussed please add performance benchmarks
Contributor
aruntyagiTutu
left a comment
aruntyagiTutu
left a comment
There was a problem hiding this comment.
Add PR description explaining the feature
Contributor
|
as discussed - Consider adding integration tests - Show it works end-to-end |
Contributor
Author
|
Will add the performance benchmarks and PR description. I am still testing few cases hence have not shared the PR in channel. |
Contributor
Author
|
@aruntyagiTutu The e2e/integrations tests are added as part of the code analyer cli and not in core. Currently the feature is gated with false feature. I can add the integration tests in cli once we make this feature user configurable from config yml file. |
aruntyagiTutu
approved these changes
Mar 18, 2026
nikhil-mittal-165
pushed a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are to add inline suppression marker in the Code Analyzer. User can use these in their source code to suppress violations in particular blocks of code. We are allowing following levels of suppress/unsuppress markers:
1- suppress(all)
2- suppress(engine)
3- suppress(engine:ruleName)
4- suppress(engine:[severities])
Demo: https://drive.google.com/file/d/1H0XzMkxV4wIi3qXdCmq0cXyw4JeOchJn/view?usp=sharing
Manual Testing: https://docs.google.com/document/d/1_8ntH7uL1DkDfoNbubN2UiQKD7J6UYiYLMX4K5ocm8w/edit?usp=sharing
Performance Implications: https://docs.google.com/document/d/1_8ntH7uL1DkDfoNbubN2UiQKD7J6UYiYLMX4K5ocm8w/edit?usp=sharing