@W-13931419 | removing debug logs in TaxCartCalculator sample apex in 246 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swati681
approved these changes
Aug 30, 2023
msalian01
reviewed
Aug 31, 2023
msalian01
left a comment
msalian01
left a comment
There was a problem hiding this comment.
@shivani-khandelwal , the WorkItem says , the class should extend CartExtension.TaxCartCalculator instead of CartExtension.AbstractCartCalculator. are we not covering it ?
Collaborator
Author
|
@msalian01 , that would be taken care of by sneha as part of a different item. You can refer to that discussion in the WI feed for more details. |
Sure, With GUS feed , i got the impression that should have been already covered. Approving from my side. |
msalian01
approved these changes
Aug 31, 2023
ParameshOddepally
approved these changes
Aug 31, 2023
simkapur
approved these changes
Aug 31, 2023
shivani-khandelwal
force-pushed
the
local246branch
branch
5 times, most recently
from
fec738b to
3a9d22a
Compare
shivani-khandelwal
force-pushed
the
local246branch
branch
from
af687b3 to
78d5e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001Y8GM7YAN/view