@W-17966639 Calculator changes to retain previous selected delivery method #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf-anilpurohit
changed the title
Collaborator
Author
|
Hi @gurpreetsainisalesforce @snilakandan13 Thanks! |
Collaborator
|
@sf-anilpurohit Please check if any additional tests are required for this change. |
|
@sf-anilpurohit I have a general concern regarding this work — I always think that we should keep our sample code simple and easy to understand. In the past, I have seen multiple customers misused/misunderstood our sample code. It’s unnecessarily long and complicated. Also, sample code is not for production usage, if our partners/customers want extra business logic implemented, they can do it on top of sample code. I am afraid that, by making the sample code longer and more complicated, it doesn’t serve the purpose of sample code well. |
…commerce/W-17966639-1
Collaborator
|
@sf-anilpurohit Can you please close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In This PR we have changed Apex sample code for ShippingCartCalculatorSample to retain previously selected delivery method when we retrigger shipping calculation from buyer flow.
What issues does this PR fix or reference?
#, @@
@W-17966639
Functionality Before
<insert gif and/or summary>
Earlier we were not retaining previously selected delivery method and it was always getting clear then buyer need to select again if he change the delivery address.
Functionality After
<insert gif and/or summary>
Now we are retaining previously selected delivery method and it wont clear if buyer change the delivery address.
How to Test/Testing Effort
<insert gif and/or summary>
by placing order in checkout flow by selecting one of CDGM and changing the address we can test it.