fix: bug that made some calculations wrong (#135)

form3tech-oss · Sep 12, 2023 · 52025dc · 52025dc
1 parent ed5db48
commit 52025dc
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/internal/trigger/gaussian/gaussian_rate.go b/internal/trigger/gaussian/gaussian_rate.go
@@ -225,5 +225,5 @@ func parseRateToTPS(rateArg string) (float64, error) {
 	if err != nil {
 		return -1, fmt.Errorf("parse to tps %s: %w", rateArg, err)
 	}
-	return float64(rate) * unit.Seconds(), nil
+	return float64(rate) / unit.Seconds(), nil
 }
diff --git a/internal/trigger/gaussian/gaussian_rate_test.go b/internal/trigger/gaussian/gaussian_rate_test.go
@@ -249,6 +249,14 @@ func Test_calculateVolume(t *testing.T) {
 			want:     358629,
 			wantErr:  false,
 		},
+		{
+			name:     "10TPS 2",
+			peakTps:  "100/10s",
+			stddev:   4 * time.Hour,
+			peakTime: 14 * time.Hour,
+			want:     358629,
+			wantErr:  false,
+		},
 		{
 			name:     "10TPS no unit",
 			peakTps:  "10",
@@ -257,12 +265,28 @@ func Test_calculateVolume(t *testing.T) {
 			want:     358629,
 			wantErr:  false,
 		},
+		{
+			name:     "1TPms",
+			peakTps:  "1/ms",
+			stddev:   4 * time.Hour,
+			peakTime: 14 * time.Hour,
+			want:     35862889,
+			wantErr:  false,
+		},
 		{
 			name:     "1000TPms",
 			peakTps:  "1000/ms",
 			stddev:   4 * time.Hour,
 			peakTime: 14 * time.Hour,
-			want:     35863,
+			want:     35862888782,
+			wantErr:  false,
+		},
+		{
+			name:     "1TPH",
+			peakTps:  "1/h",
+			stddev:   4 * time.Hour,
+			peakTime: 14 * time.Hour,
+			want:     10,
 			wantErr:  false,
 		},
 		{