General improvements to the ECMA-SL syntax #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes dynamic types from the lexer/parser, as they are now represented by normal strings in the typeof operator. Therefore, there is no need to store a type as a value. This change should not break any existing functionality.
andreffnascimento
changed the title
andreffnascimento
added
no changelog
filipeom
reviewed
Jun 27, 2024
| | App (`Op "TupleType", []) | ||
| | App (`Op "CurryType", []) -> | ||
| Str "type" | ||
| | App (`Op "type", [ Str _ ]) -> Str "type" |
There was a problem hiding this comment.
Suggested change
| | App (`Op "type", [ Str _ ]) -> Str "type" | |
| | App (`Op "type", [ Str _ ]) -> Str "type" |
I don't understand why we still need this? This PR removes parsing of Types, so we should never create this value right?
There was a problem hiding this comment.
Absolutely, I went over this file before I removed the types
filipeom
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we give a general overall to the ECMA-SL syntax (this is useful before starting #130). Additionally, we fix a couple of problems introduced in #128. The list of changes is the following:
T1: In this commit, we merged all the metadata files (e.g.,
eFunc_metadata,EPat_metadata, etc.) into a single file. Additionally, we removed a few unused functions and improved overall consistency.T2: In this commit, we separated the
Syntax.SourceandSyntax.Source.Codemodules in two different files. Since the latter is only used to store the parsed code, it is not needed in the language syntax, and thus was moved to theCode_utils.mlfile.T3: In this commit, we encapsulated
Smtml.Valuein our ownValuemodule, similar to what we did with theFormatmodule. This allows us to store value-related functions within this module instead of storing them in theEExprmodule. Additionally, we no longer require opening theSmtmlmodule (generally) as the value can now be directly accessed through theESLSyntaxlibrary. Finally, we removed type values, since dynamic types are now represented by normal string values.T4: In this commit, we replaced the
Typemodule with the types fromSmtml. Dynamic types are not needed any longer, and this allows symbolic expressions to immediately storeSmtmltypes rather than having to convert the old dynamic types into these.