fix: dev envs

[gfyrag]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@gfyrag has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5b46a5f and b7a6384.

📒 Files selected for processing (1)

• Earthfile (2 hunks)

Walkthrough

The deployment logic in the Earthfile was updated to always set the server.address Helm parameter to membership.formance.svc.cluster.local:8082, removing previous conditional logic that depended on the FORMANCE_DEV_CLUSTER_V2 environment variable. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
Earthfile	Removed conditional assignment for server.address in Helm deployment; now always uses membership.formance.svc.cluster.local:8082.

Possibly related PRs

• feat: devenvs #135: Introduced the conditional logic for server.address based on FORMANCE_DEV_CLUSTER_V2, which this PR now removes.

Suggested reviewers

• fguery

Poem

In the warren of code, a change hops by,
No more ifs or elses—just one address to try.
Helm charts march in single file,
Cluster local, in rabbit style.
Simpler now, with less to guess—
A tidy burrow, free from mess! 🐇

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch fix/devenvs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Earthfile (1)

120-127: Consider cleanup: Conditional logic still references FORMANCE_DEV_CLUSTER_V2

The conditional block for FORMANCE_DEV_CLUSTER_V2 remains but no longer affects server.address. Since the server address is now standardized, consider whether this conditional logic is still necessary or if it should be simplified.

If the conditional behavior is still needed for the other parameters (imagePullSecrets, TLS settings, monitoring endpoints), the current implementation is fine. However, if the goal is to fully standardize dev environment configuration, you might consider removing or simplifying this conditional logic as well.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between baed701 and 5b46a5f.

📒 Files selected for processing (1)

• Earthfile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Dirty

🔇 Additional comments (1)

Earthfile (1)

135-135: Standardizing server.address – please verify environment impact

The unconditional --set server.address=membership.formance.svc.cluster.local:8082 aligns with the PR’s goal to simplify dev deployments. Before merging, please:

• Confirm there are no remaining conditional references to $user.$tld or $user.$tld:443 in the Earthfile (e.g. around the FORMANCE_DEV_CLUSTER_V2 block on lines ~121–127).
• Validate that production and any non-dev environments still resolve to the intended host/port.
• Clean up any now-unused conditional logic or comments related to server.address.

[cursor]

Bug: Server Address Regression in Non-Dev

The conditional logic for server.address was removed, causing it to unconditionally be membership.formance.svc.cluster.local:8082. Previously, non-dev environments (when FORMANCE_DEV_CLUSTER_V2 was not 'yes') used $user.$tld:443. This change forces non-dev deployments to use the internal dev address, potentially breaking them. Additionally, other development-specific settings (e.g., TLS, imagePullSecrets) remain conditional, leading to an inconsistent configuration for non-dev environments.

Earthfile#L120-L136

agent/Earthfile

Lines 120 to 136 in b7a6384

	ARG FORMANCE_DEV_CLUSTER_V2=no
	IF [ "$FORMANCE_DEV_CLUSTER_V2" == "yes" ]
	SET ADDITIONAL_ARGS="$ADDITIONAL_ARGS --set imagePullSecrets[0].name=zot"
	SET ADDITIONAL_ARGS="$ADDITIONAL_ARGS --set server.tls.enabled=false"
	SET ADDITIONAL_ARGS="$ADDITIONAL_ARGS --set global.monitoring.traces.endpoint=otel-shared-admin.default.svc.cluster.local"
	SET ADDITIONAL_ARGS="$ADDITIONAL_ARGS --set global.monitoring.metrics.endpoint=otel-shared-admin.default.svc.cluster.local"
	SET ADDITIONAL_ARGS="$ADDITIONAL_ARGS --set image.repository=$REPOSITORY/formancehq/agent"
	END
	RUN --secret tld helm upgrade --namespace formance \
	--create-namespace \
	--install \
	--wait \
	-f .earthly/values.yaml \
	--set image.tag=$tag \
	--set agent.baseUrl=https://$user.$tld \
	--set server.address=membership.formance.svc.cluster.local:8082 \
	formance-membership-agent ./helm $ADDITIONAL_ARGS

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎