Skip to content

fix: dev deployment #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

fix: dev deployment #140

merged 1 commit into from
Jul 4, 2025

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jul 4, 2025

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner July 4, 2025 12:05
Copy link

coderabbitai bot commented Jul 4, 2025

Walkthrough

The Helm upgrade command in the deploy target of the Earthfile was updated to use the formance-system namespace instead of formance. No other parameters or commands were altered.

Changes

File(s) Change Summary
Earthfile Updated Helm upgrade command to use formance-system namespace instead of formance.

Possibly related PRs

  • feat: devenvs #135: Changes the Helm upgrade namespace in the opposite direction, modifying the same deployment command but switching namespaces from formance-system to formance.

Poem

A namespace shift, a gentle breeze,
From formance to formance-system with ease.
Helm charts now know where to land,
In Kubernetes' careful hand.
Rabbits hop and clusters sing,
For tidy configs that changes bring! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3022e17 and 5ea61fe.

📒 Files selected for processing (1)
  • Earthfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Dirty
🔇 Additional comments (1)
Earthfile (1)

128-128: Verify cross-namespace communication after namespace change

The namespace update in Earthfile (line 128) to formance-system is correct and there are no other hardcoded references to the old formance namespace. However, because the agent still points to the membership service in the formance namespace, please verify at runtime that cross-namespace DNS and network policies allow:

• Earthfile:128 – --namespace formance-system
• Earthfile:135 – --set server.address=membership.formance.svc.cluster.local:8082

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in a Comment
  • Commit Unit Tests in branch fix/agent-namesapce

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gfyrag gfyrag enabled auto-merge (squash) July 4, 2025 12:06
@gfyrag gfyrag merged commit 80dee1c into main Jul 4, 2025
3 of 4 checks passed
@gfyrag gfyrag deleted the fix/agent-namesapce branch July 4, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants