Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: portal and console image pull secret #59

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Oct 22, 2024

  • feat: portal, console imagePullSecrets

@Dav-14 Dav-14 requested a review from a team as a code owner October 22, 2024 07:55
Copy link

gitguardian bot commented Oct 22, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14246238 Triggered Generic Password e48895f charts/cloudprem/profiles/11-membership-multi-user.yaml View secret
4298688 Triggered Generic Password e48895f charts/cloudprem/profiles/11-membership-multi-user.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Dav-14 Dav-14 force-pushed the feat/console-portal-image-pull-secrets branch 2 times, most recently from ab297ea to 8df40a0 Compare October 22, 2024 07:57
@Dav-14 Dav-14 force-pushed the feat/console-portal-image-pull-secrets branch from 8df40a0 to e48895f Compare October 22, 2024 08:58
@Dav-14 Dav-14 merged commit ae65700 into main Oct 22, 2024
3 of 4 checks passed
@Dav-14 Dav-14 deleted the feat/console-portal-image-pull-secrets branch October 22, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants