Skip to content

chore: exclude 3rd party code from line duplication #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

mattinannt
Copy link
Member

This pull request updates the SonarQube configuration to exclude specific third-party files from duplication analysis.

We are excluding the AnyCodable helper files from SonarQube's duplicated lines analysis because these files are derived from the open-source Flight-School/AnyCodable library (https://github.com/Flight-School/AnyCodable) and are considered vendor/third-party code. Refactoring or modifying them would make it difficult to update from the upstream source and is not recommended. Excluding such files from duplication checks is a standard practice for vendor code, as we are not responsible for their structure or code quality.

Configuration updates:

  • sonar-project.properties: Added sonar.cpd.exclusions to exclude Sources/FormbricksSDK/Helpers/AnyCodable/*.swift from duplication checks. These files are derived from the open-source Flight-School/AnyCodable library and are considered vendor code, making them unsuitable for refactoring or modification.

@mattinannt mattinannt merged commit d0e9b4e into main May 15, 2025
2 checks passed
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant