chore: add more tests to survey manager #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
SurveyManager
class and its test coverage in theFormbricksSDK
. The key updates include modifying access levels for methods, refactoring helper methods, and adding comprehensive test cases to improve code reliability and maintainability.Changes to
SurveyManager
:private
tointernal
forrefreshEnvironmentAfter
,shouldDisplayBasedOnPercentage
, andgetLanguageCode
to allow broader access within the module. [1] [2] [3]private extension SurveyManager
toextension SurveyManager
, making them accessible as part of the main class extension.Test Coverage Enhancements:
testSurveyManagerEdgeCases
, inFormbricksSDKTests
to cover edge scenarios forSurveyManager
. This includes testing:shouldDisplayBasedOnPercentage
for various input values.UserDefaults
data.getLanguageCode
with different language configurations.