fix: recontact days calculation #20
Conversation
WalkthroughThe change updates the implementation of the Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
A fix to ensure the daysBetween method always returns a non-negative count by wrapping the computed value in abs.
- Applied
absto the day difference calculation. - Maintained the existing inclusive-day logic (
+ 1).
Comments suppressed due to low confidence (2)
Sources/FormbricksSDK/Extension/Calendar+DaysBetween.swift:10
- Add unit tests for cases where the
todate is before thefromdate to ensure the result is always positive and matches expected behavior.
return abs(numberOfDays.day! + 1)
Sources/FormbricksSDK/Extension/Calendar+DaysBetween.swift:7
- Update or add a doc comment on
daysBetweento clarify that it now always returns a non-negative count, even if the end date precedes the start date.
extension Calendar {
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Sources/FormbricksSDK/Extension/Calendar+DaysBetween.swift (1)
10-10: Good fix for ensuring positive day count.The change to use
abs()ensures the function always returns a positive value regardless of the date order, which aligns with the expected behavior for calculating days between two dates.However, there are two points to consider:
- The force unwrapping (
numberOfDays.day!) could potentially crash if the day component is nil- The documentation comment doesn't mention that the method returns a positive value regardless of date order
Consider enhancing the function documentation to clarify the behavior:
- /// Returns the number of days between two dates. + /// Returns the positive number of days between two dates, regardless of their chronological order.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Sources/FormbricksSDK/Extension/Calendar+DaysBetween.swift(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-and-analyze
|
This pull request includes a small but important fix to the
Calendarextension inSources/FormbricksSDK/Extension/Calendar+DaysBetween.swift. The change ensures that thedaysBetweencalculation always returns a positive value by applying theabsfunction to the result.Summary by CodeRabbit